Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CLI: Lookup access controller and authority in manage_subscription.py #300

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

KPrasch
Copy link
Member

@KPrasch KPrasch commented Aug 7, 2024

Type of PR:
Feature (follow-up)

Required reviews:
1

What this does:

  • Removes the need for the --access-controller option when adding /removing encryptors (using an onchain read and the ape's integration with polygonscan API)
  • Eager enforcement of authority account when adding/removing encryptors
  • makes --network a required option
  • Adds missing shebang
  • lint and format

Notes for reviewers:
Follow up for pr #299

@KPrasch KPrasch changed the base branch from epic-subscription to main August 14, 2024 08:12
@KPrasch KPrasch requested review from derekpierre and removed request for derekpierre August 15, 2024 13:10
scripts/manage_subscription.py Outdated Show resolved Hide resolved
scripts/manage_subscription.py Outdated Show resolved Hide resolved
scripts/manage_subscription.py Outdated Show resolved Hide resolved
scripts/manage_subscription.py Outdated Show resolved Hide resolved
KPrasch and others added 2 commits August 15, 2024 15:58
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@KPrasch KPrasch merged commit 76daac1 into nucypher:main Aug 15, 2024
2 checks passed
theref pushed a commit to theref/nucypher-contracts that referenced this pull request Aug 26, 2024
Apply RFRs in PR nucypher#300

Co-authored-by: Derek Pierre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants